Skip to content

Clarify these features are not related to Next #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

lunaleaps
Copy link
Contributor

There was some discussion online that the warning mentioning Next may give the impression this is a NextJS feature.

What if we leave it just as a blank warning for now? I can see the appeal of linking to something vs. nothing but I do hope to get these fleshed out soon. What do you think?

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.01 KB (🟢 -27 B) 180.96 KB
/500 77.01 KB (🟢 -26 B) 180.96 KB
/[[...markdownPath]] 78.47 KB (🟢 -27 B) 182.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine, could also go with something like

This API can be used in any framework that supports React Server Components, but the Next.js documentation may answer additional questions.

@rickhanlonii
Copy link
Member

@sophiebits @lunaleaps yeah, and when other frameworks add support and docs, we can also add links to those docs.

This API can be used in any framework that supports React Server Components:

  • Next.js Server Components
  • More coming soon

@lunaleaps lunaleaps merged commit f67811b into reactjs:main Aug 21, 2023
@lunaleaps lunaleaps deleted the clarify-warning branch August 21, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants